Reverts #6478 - removes debounce on search #6497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
For some reason |
bmuenzenmeyer
approved these changes
Mar 20, 2024
|
Thank you so much @bmuenzenmeyer, definitely not a problem on our side |
marco-ippolito
approved these changes
Mar 20, 2024
AugustinMauroy
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
@micheleriva if the boss says it's like that then we do as the boss says 😎
|
Could I propose this gets fast-tracked as a fix for a relatively substantial issue? There have been discussions on Twitter about how unresponsive the search is. |
bmuenzenmeyer
added
fast-track
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
|
Totally agree with @MattIPv4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts #6478. Please do not apply a debounce function when searching with Orama, it's not needed and it's killing the user experience. We offer unlimited searches so it's ok to send us even billions of them 🙂
Validation
Related Issues
Check List
npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing.npx turbo buildto check if the website builds without errors.